diff --git a/module/Oscar/src/Oscar/Entity/RecallDeclaration.php b/module/Oscar/src/Oscar/Entity/RecallDeclaration.php index 5f4a6f750b1a958cc3b761b3a6c11182e82040f5..ee3a6c6b62bd7440a7dd109cdab6fbe748d8c84f 100644 --- a/module/Oscar/src/Oscar/Entity/RecallDeclaration.php +++ b/module/Oscar/src/Oscar/Entity/RecallDeclaration.php @@ -120,7 +120,7 @@ class RecallDeclaration public function getShipmentsLogs() :string { - return implode($this->getShipments(), "\n"); + return implode( "\n", $this->getShipments() ); } public function getPeriod() :string @@ -267,4 +267,4 @@ class RecallDeclaration } -} \ No newline at end of file +} diff --git a/module/Oscar/src/Oscar/Import/ImportLaboratory.php b/module/Oscar/src/Oscar/Import/ImportLaboratory.php index 9c9fd4af99c0e0a09b14bcab5966e7320730762c..3933e7a680439e54e5c8aa6236fd4a2bec6c39f4 100644 --- a/module/Oscar/src/Oscar/Import/ImportLaboratory.php +++ b/module/Oscar/src/Oscar/Import/ImportLaboratory.php @@ -77,7 +77,7 @@ class ImportLaboratory extends AbstractImportStrategy 'cleaner' => function( $data ) { return $this->cleanBullshitStr($data);} ), ]); - $query = sprintf("SELECT CLEUNIK, TYPE, %s FROM OSCAR_PARTENAIRE", implode($hydrator->listFields(), ',')); + $query = sprintf("SELECT CLEUNIK, TYPE, %s FROM OSCAR_PARTENAIRE", implode(',', $hydrator->listFields())); $this->getLogger()->info($query); $stid = oci_parse($c, $query); oci_execute($stid); @@ -229,4 +229,4 @@ class ImportLaboratory extends AbstractImportStrategy } } -} \ No newline at end of file +} diff --git a/module/Oscar/src/Oscar/Import/ImportPartners.php b/module/Oscar/src/Oscar/Import/ImportPartners.php index fde06bfcb0cb2561a446c91fcde095b4d3d19808..26805decad05fc71aa2f1ebf95fb38a38694a4ba 100644 --- a/module/Oscar/src/Oscar/Import/ImportPartners.php +++ b/module/Oscar/src/Oscar/Import/ImportPartners.php @@ -78,7 +78,7 @@ class ImportPartners extends AbstractImportStrategy 'cleaner' => function( $data ) { return $this->cleanBullshitStr($data);} ), ]); - $query = sprintf("SELECT CLEUNIK, TYPE, %s FROM OSCAR_PARTENAIRE_AVEC_UFR", implode($hydrator->listFields(), ',')); + $query = sprintf("SELECT CLEUNIK, TYPE, %s FROM OSCAR_PARTENAIRE_AVEC_UFR", implode(',', $hydrator->listFields())); $this->getLogger()->info($query); $stid = oci_parse($c, $query); oci_execute($stid); @@ -376,4 +376,4 @@ class ImportPartners extends AbstractImportStrategy } } } -} \ No newline at end of file +} diff --git a/module/Oscar/src/Oscar/Service/PCRUService.php b/module/Oscar/src/Oscar/Service/PCRUService.php index d5483711a05409632bcb83ea87978da5d1af730e..20b81af1a5fc01b3ad798bb4650197e43bad2565 100644 --- a/module/Oscar/src/Oscar/Service/PCRUService.php +++ b/module/Oscar/src/Oscar/Service/PCRUService.php @@ -877,7 +877,7 @@ class PCRUService implements UseLoggerService, UseOscarConfigurationService, Use } else { foreach($json_errors->contratsWithErrors as $error){ $activityOscarId = $error->id; - $errors = implode($error->errors, ", "); + $errors = implode(', ', $error->errors ); $this->log("Activity mark as error '$activityOscarId' : '$errors'"); $pcruinfos = $this->getActivityPCRUInfoRepository()->getPcruInfoActivityFromOscarId($activityOscarId); $pcruinfos->setErrorsRemote($errors)