From 25b34a594125b35f420142d7cca56ddcb025dbf9 Mon Sep 17 00:00:00 2001
From: root <root@lamp02.arzt.ephe.fr>
Date: Wed, 12 Feb 2025 12:30:13 +0100
Subject: [PATCH] 
 [fix](modules/Oscar/RecallDeclaration+ImportLaboratory+ImportPartners+PCRUService
 php files): Fix error wrong implode method use. #1 param must be a the
 delimiter.

---
 module/Oscar/src/Oscar/Entity/RecallDeclaration.php | 4 ++--
 module/Oscar/src/Oscar/Import/ImportLaboratory.php  | 4 ++--
 module/Oscar/src/Oscar/Import/ImportPartners.php    | 4 ++--
 module/Oscar/src/Oscar/Service/PCRUService.php      | 2 +-
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/module/Oscar/src/Oscar/Entity/RecallDeclaration.php b/module/Oscar/src/Oscar/Entity/RecallDeclaration.php
index 5f4a6f750..ee3a6c6b6 100644
--- a/module/Oscar/src/Oscar/Entity/RecallDeclaration.php
+++ b/module/Oscar/src/Oscar/Entity/RecallDeclaration.php
@@ -120,7 +120,7 @@ class RecallDeclaration
 
     public function getShipmentsLogs() :string
     {
-        return implode($this->getShipments(), "\n");
+        return implode( "\n", $this->getShipments() );
     }
 
     public function getPeriod() :string
@@ -267,4 +267,4 @@ class RecallDeclaration
     }
 
 
-}
\ No newline at end of file
+}
diff --git a/module/Oscar/src/Oscar/Import/ImportLaboratory.php b/module/Oscar/src/Oscar/Import/ImportLaboratory.php
index 9c9fd4af9..3933e7a68 100644
--- a/module/Oscar/src/Oscar/Import/ImportLaboratory.php
+++ b/module/Oscar/src/Oscar/Import/ImportLaboratory.php
@@ -77,7 +77,7 @@ class ImportLaboratory extends AbstractImportStrategy
                 'cleaner'   => function( $data ) { return $this->cleanBullshitStr($data);}
             ),
         ]);
-        $query = sprintf("SELECT CLEUNIK, TYPE, %s FROM OSCAR_PARTENAIRE", implode($hydrator->listFields(), ','));
+        $query = sprintf("SELECT CLEUNIK, TYPE, %s FROM OSCAR_PARTENAIRE", implode(',', $hydrator->listFields()));
         $this->getLogger()->info($query);
         $stid = oci_parse($c, $query);
         oci_execute($stid);
@@ -229,4 +229,4 @@ class ImportLaboratory extends AbstractImportStrategy
 
         }
     }
-}
\ No newline at end of file
+}
diff --git a/module/Oscar/src/Oscar/Import/ImportPartners.php b/module/Oscar/src/Oscar/Import/ImportPartners.php
index fde06bfcb..26805deca 100644
--- a/module/Oscar/src/Oscar/Import/ImportPartners.php
+++ b/module/Oscar/src/Oscar/Import/ImportPartners.php
@@ -78,7 +78,7 @@ class ImportPartners extends AbstractImportStrategy
                 'cleaner'   => function( $data ) { return $this->cleanBullshitStr($data);}
             ),
         ]);
-        $query = sprintf("SELECT CLEUNIK, TYPE, %s FROM OSCAR_PARTENAIRE_AVEC_UFR", implode($hydrator->listFields(), ','));
+        $query = sprintf("SELECT CLEUNIK, TYPE, %s FROM OSCAR_PARTENAIRE_AVEC_UFR", implode(',', $hydrator->listFields()));
         $this->getLogger()->info($query);
         $stid = oci_parse($c, $query);
         oci_execute($stid);
@@ -376,4 +376,4 @@ class ImportPartners extends AbstractImportStrategy
             }
         }
     }
-}
\ No newline at end of file
+}
diff --git a/module/Oscar/src/Oscar/Service/PCRUService.php b/module/Oscar/src/Oscar/Service/PCRUService.php
index d5483711a..20b81af1a 100644
--- a/module/Oscar/src/Oscar/Service/PCRUService.php
+++ b/module/Oscar/src/Oscar/Service/PCRUService.php
@@ -877,7 +877,7 @@ class PCRUService implements UseLoggerService, UseOscarConfigurationService, Use
         } else {
             foreach($json_errors->contratsWithErrors as $error){
                 $activityOscarId = $error->id;
-                $errors = implode($error->errors, ", ");
+                $errors = implode(', ', $error->errors );
                 $this->log("Activity mark as error '$activityOscarId' : '$errors'");
                 $pcruinfos = $this->getActivityPCRUInfoRepository()->getPcruInfoActivityFromOscarId($activityOscarId);
                 $pcruinfos->setErrorsRemote($errors)
-- 
GitLab