Add spec for postfix::hash and refactor it

manifests/hash.pp

@@ -26,50 +26,36 @@
 #    }
 #  }
 #
-define postfix::hash ($ensure='present', $source=false, $content=false) {
+define postfix::hash (
+  $ensure='present',
+  $source=undef,
+  $content=undef,
+) {
+  include ::postfix::params
 
-  # selinux labels differ from one distribution to another
-  case $::operatingsystem {
+  validate_absolute_path($name)
+  validate_string($source)
+  validate_string($content)
+  validate_string($ensure)
+  validate_re($ensure, ['present', 'absent'],
+    "\$ensure must be either 'present' or 'absent', got '${ensure}'")
 
-    RedHat, CentOS: {
-      case $::lsbmajdistrelease {
-        '4':     { $postfix_seltype = 'etc_t' }
-        '5','6': { $postfix_seltype = 'postfix_etc_t' }
-        default: { $postfix_seltype = undef }
-      }
-    }
-
-    default: {
-      $postfix_seltype = undef
-    }
+  if $source and $content {
+    fail "You must provide either 'source' or 'content', not both"
   }
 
   File {
     mode    => '0600',
     owner   => root,
     group   => root,
-    seltype => $postfix_seltype,
+    seltype => $postfix::params::seltype,
   }
 
-  if $source != false {
-    file {$name:
-      ensure  => $ensure,
-      source  => $source,
-      require => Package['postfix'],
-    }
-  } else {
-    if $content != false {
-      file {$name:
-        ensure  => $ensure,
-        content => $content,
-        require => Package['postfix'],
-      }
-    } else {
-      file {$name:
-        ensure  => $ensure,
-        require => Package['postfix'],
-      }
-    }
+  file { $name:
+    ensure  => $ensure,
+    source  => $source,
+    content => $content,
+    require => Package['postfix'],
   }
 
   file {"${name}.db":

spec/defines/postfix_hash_spec.rb

+require 'spec_helper'
+
+describe 'postfix::hash' do
+  let (:title) { '/tmp/foo' }
+  let (:facts) { {
+    :osfamily => 'Debian',
+  } }
+
+  context 'when passing wrong type for ensure' do
+    let (:params) { {
+      :ensure => ['present'],
+    } }
+    it 'should fail' do
+      expect {
+        should contain_file('/tmp/foo')
+      }.to raise_error(Puppet::Error, /\["present"\] is not a string/)
+    end
+  end
+
+  context 'when passing wrong value for ensure' do
+    let (:params) { {
+      :ensure => 'running',
+    } }
+    it 'should fail' do
+      expect {
+        should contain_file('/tmp/foo')
+      }.to raise_error(Puppet::Error, /must be either 'present' or 'absent'/)
+    end
+  end
+
+  context 'when passing wrong value for title' do
+    let (:title) { 'foo' }
+    it 'should fail' do
+      expect {
+        should contain_file('/tmp/foo')
+      }.to raise_error(Puppet::Error, /"foo" is not an absolute path/)
+    end
+  end
+
+  context 'when passing both source and content' do
+    let (:params) { {
+      :source  => '/tmp/bar',
+      :content => 'bar',
+    } }
+
+    it 'should fail' do
+      expect {
+        should contain_file('/tmp/foo')
+      }.to raise_error(Puppet::Error, /You must provide either 'source' or 'content'/)
+    end
+  end
+
+  context 'when passing source' do
+    let (:params) { {
+      :source  => '/tmp/bar',
+    } }
+
+    it { should contain_file('/tmp/foo').with(
+        :ensure => 'present',
+        :source => '/tmp/bar'
+      ).without(:content)
+    }
+    it { should contain_file('/tmp/foo.db').with_ensure('present') }
+    it { should contain_exec('generate /tmp/foo.db') }
+  end
+
+  context 'when passing content' do
+    let (:params) { {
+      :content => 'bar',
+    } }
+
+    it { should contain_file('/tmp/foo').with(
+        :ensure  => 'present',
+        :content => 'bar'
+      ).without(:source)
+    }
+    it { should contain_file('/tmp/foo.db').with_ensure('present') }
+    it { should contain_exec('generate /tmp/foo.db') }
+  end
+
+  context 'when not passing source or content' do
+    it { should contain_file('/tmp/foo').with(
+        :ensure  => 'present'
+      ).without(:source).without(:content)
+    }
+    it { should contain_file('/tmp/foo.db').with_ensure('present') }
+    it { should contain_exec('generate /tmp/foo.db') }
+  end
+
+  context 'when ensuring absence' do
+    let (:params) { {
+      :ensure => 'absent',
+    } }
+
+    it { should contain_file('/tmp/foo').with_ensure('absent') }
+    it { should contain_file('/tmp/foo.db').with_ensure('absent') }
+    it { should contain_exec('generate /tmp/foo.db') }
+  end
+end