Unverified Commit 0541d259 authored by Nathan Ward's avatar Nathan Ward Committed by GitHub
Browse files

Merge pull request #159 from SearchLightNZ/pdk_2.1.0 

Update to PDK 2.1.0
parents 094845c2 5a682650

.devcontainer/Dockerfile

0 → 100644
+6 −0
Original line number Diff line number Diff line 
FROM puppet/pdk:latest



# [Optional] Uncomment this section to install additional packages.

# RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \

#     && apt-get -y install --no-install-recommends <your-package-list-here>

.devcontainer/devcontainer.json

0 → 100644
+23 −0
Original line number Diff line number Diff line 
// For format details, see https://aka.ms/devcontainer.json. For config options, see the README at:

// https://github.com/microsoft/vscode-dev-containers/tree/v0.140.1/containers/puppet

{

	"name": "Puppet Development Kit (Community)",

	"dockerFile": "Dockerfile",



	// Set *default* container specific settings.json values on container create.

	"settings": {

		"terminal.integrated.shell.linux": "/bin/bash"

	},



	// Add the IDs of extensions you want installed when the container is created.

	"extensions": [

		"puppet.puppet-vscode",

		"rebornix.Ruby"

	]



	// Use 'forwardPorts' to make a list of ports inside the container available locally.

	// "forwardPorts": [],



	// Use 'postCreateCommand' to run commands after the container is created.

	// "postCreateCommand": "pdk --version",

}

.gitlab-ci.yml

+25 −16
Original line number Diff line number Diff line
@@ -3,11 +3,12 @@ stages: 
  - syntax

  - unit



default:

  cache:

    paths:

      - vendor/bundle



before_script:

  before_script: &before_script

    - bundle -v

    - rm Gemfile.lock || true

    - "# Update system gems if requested. This is useful to temporarily workaround troubles in the test runner"
@@ -34,11 +35,19 @@ parallel_spec-Ruby 2.5.7-Puppet ~> 6: 
  variables:

    PUPPET_GEM_VERSION: '~> 6'



parallel_spec-Ruby 2.4.5-Puppet ~> 5:

syntax lint metadata_lint check:symlinks check:git_ignore check:dot_underscore check:test_file rubocop-Ruby 2.7.2-Puppet ~> 7:

  stage: syntax

  image: ruby:2.7.2

  script:

    - bundle exec rake syntax lint metadata_lint check:symlinks check:git_ignore check:dot_underscore check:test_file rubocop

  variables:

    PUPPET_GEM_VERSION: '~> 7'



parallel_spec-Ruby 2.7.2-Puppet ~> 7:

  stage: unit

  image: ruby:2.4.5

  image: ruby:2.7.2

  script:

    - bundle exec rake parallel_spec

  variables:

    PUPPET_GEM_VERSION: '~> 5'

    PUPPET_GEM_VERSION: '~> 7'

.pdkignore

+3 −0
Original line number Diff line number Diff line
@@ -32,6 +32,7 @@ 
/.gitignore

/.gitlab-ci.yml

/.pdkignore

/.puppet-lint.rc

/Rakefile

/rakelib/

/.rspec
@@ -40,3 +41,5 @@ 
/.yardopts

/spec/

/.vscode/

/.sync.yml

/.devcontainer/

.rubocop.yml

+403 −21
Original line number Diff line number Diff line 
---

require:

- rubocop-performance

- rubocop-rspec

- rubocop-i18n

AllCops:

  DisplayCopNames: true

  TargetRubyVersion: '2.1'

  TargetRubyVersion: '2.4'

  Include:

  - "./**/*.rb"

  - "**/*.rb"

  Exclude:

  - bin/*

  - ".vendor/**/*"
@@ -18,16 +18,9 @@ AllCops: 
  - "**/Puppetfile"

  - "**/Vagrantfile"

  - "**/Guardfile"

Metrics/LineLength:

Layout/LineLength:

  Description: People have wide screens, use them.

  Max: 200

GetText:

  Enabled: false

GetText/DecorateString:

  Description: We don't want to decorate test output.

  Exclude:

  - spec/**/*

  Enabled: false

RSpec/BeforeAfterAll:

  Description: Beware of using after(:all) as it may cause state to leak between tests.

    A necessary evil in acceptance testing.
@@ -36,14 +29,13 @@ RSpec/BeforeAfterAll: 
RSpec/HookArgument:

  Description: Prefer explicit :each argument, matching existing module's style

  EnforcedStyle: each

RSpec/DescribeSymbol:

  Exclude:

  - spec/unit/facter/**/*.rb

Style/BlockDelimiters:

  Description: Prefer braces for chaining. Mostly an aesthetical choice. Better to

    be consistent then.

  EnforcedStyle: braces_for_chaining

Style/BracesAroundHashParameters:

  Description: Braces are required by Ruby 2.7. Cop removed from RuboCop v0.80.0.

    See https://github.com/rubocop-hq/rubocop/pull/7643

  Enabled: true

Style/ClassAndModuleChildren:

  Description: Compact style reduces the required amount of indentation.

  EnforcedStyle: compact
@@ -72,7 +64,7 @@ Style/TrailingCommaInArguments: 
  Description: Prefer always trailing comma on multiline argument lists. This makes

    diffs, and re-ordering nicer.

  EnforcedStyleForMultiline: comma

Style/TrailingCommaInLiteral:

Style/TrailingCommaInArrayLiteral:

  Description: Prefer always trailing comma on multiline literals. This makes diffs,

    and re-ordering nicer.

  EnforcedStyleForMultiline: comma
@@ -87,26 +79,170 @@ Style/Documentation: 
  - spec/**/*

Style/WordArray:

  EnforcedStyle: brackets

Performance/AncestorsInclude:

  Enabled: true

Performance/BigDecimalWithNumericArgument:

  Enabled: true

Performance/BlockGivenWithExplicitBlock:

  Enabled: true

Performance/CaseWhenSplat:

  Enabled: true

Performance/ConstantRegexp:

  Enabled: true

Performance/MethodObjectAsBlock:

  Enabled: true

Performance/RedundantSortBlock:

  Enabled: true

Performance/RedundantStringChars:

  Enabled: true

Performance/ReverseFirst:

  Enabled: true

Performance/SortReverse:

  Enabled: true

Performance/Squeeze:

  Enabled: true

Performance/StringInclude:

  Enabled: true

Performance/Sum:

  Enabled: true

Style/CollectionMethods:

  Enabled: true

Style/MethodCalledOnDoEndBlock:

  Enabled: true

Style/StringMethods:

  Enabled: true

GetText/DecorateFunctionMessage:

Bundler/InsecureProtocolSource:

  Enabled: false

Gemspec/DuplicatedAssignment:

  Enabled: false

Gemspec/OrderedDependencies:

  Enabled: false

Gemspec/RequiredRubyVersion:

  Enabled: false

Gemspec/RubyVersionGlobalsUsage:

  Enabled: false

Layout/ArgumentAlignment:

  Enabled: false

Layout/BeginEndAlignment:

  Enabled: false

Layout/ClosingHeredocIndentation:

  Enabled: false

GetText/DecorateStringFormattingUsingInterpolation:

Layout/EmptyComment:

  Enabled: false

GetText/DecorateStringFormattingUsingPercent:

Layout/EmptyLineAfterGuardClause:

  Enabled: false

Layout/EmptyLinesAroundArguments:

  Enabled: false

Layout/EmptyLinesAroundAttributeAccessor:

  Enabled: false

Layout/EndOfLine:

  Enabled: false

Layout/IndentHeredoc:

Layout/FirstArgumentIndentation:

  Enabled: false

Layout/HashAlignment:

  Enabled: false

Layout/HeredocIndentation:

  Enabled: false

Layout/LeadingEmptyLines:

  Enabled: false

Layout/SpaceAroundMethodCallOperator:

  Enabled: false

Layout/SpaceInsideArrayLiteralBrackets:

  Enabled: false

Layout/SpaceInsideReferenceBrackets:

  Enabled: false

Lint/BigDecimalNew:

  Enabled: false

Lint/BooleanSymbol:

  Enabled: false

Lint/ConstantDefinitionInBlock:

  Enabled: false

Lint/DeprecatedOpenSSLConstant:

  Enabled: false

Lint/DisjunctiveAssignmentInConstructor:

  Enabled: false

Lint/DuplicateElsifCondition:

  Enabled: false

Lint/DuplicateRequire:

  Enabled: false

Lint/DuplicateRescueException:

  Enabled: false

Lint/EmptyConditionalBody:

  Enabled: false

Lint/EmptyFile:

  Enabled: false

Lint/ErbNewArguments:

  Enabled: false

Lint/FloatComparison:

  Enabled: false

Lint/HashCompareByIdentity:

  Enabled: false

Lint/IdentityComparison:

  Enabled: false

Lint/InterpolationCheck:

  Enabled: false

Lint/MissingCopEnableDirective:

  Enabled: false

Lint/MixedRegexpCaptureTypes:

  Enabled: false

Lint/NestedPercentLiteral:

  Enabled: false

Lint/NonDeterministicRequireOrder:

  Enabled: false

Lint/OrderedMagicComments:

  Enabled: false

Lint/OutOfRangeRegexpRef:

  Enabled: false

Lint/RaiseException:

  Enabled: false

Lint/RedundantCopEnableDirective:

  Enabled: false

Lint/RedundantRequireStatement:

  Enabled: false

Lint/RedundantSafeNavigation:

  Enabled: false

Lint/RedundantWithIndex:

  Enabled: false

Lint/RedundantWithObject:

  Enabled: false

Lint/RegexpAsCondition:

  Enabled: false

Lint/ReturnInVoidContext:

  Enabled: false

Lint/SafeNavigationConsistency:

  Enabled: false

Lint/SafeNavigationWithEmpty:

  Enabled: false

Lint/SelfAssignment:

  Enabled: false

Lint/SendWithMixinArgument:

  Enabled: false

Lint/ShadowedArgument:

  Enabled: false

Lint/StructNewOverride:

  Enabled: false

Lint/ToJSON:

  Enabled: false

Lint/TopLevelReturnWithArgument:

  Enabled: false

Lint/TrailingCommaInAttributeDeclaration:

  Enabled: false

Lint/UnreachableLoop:

  Enabled: false

Lint/UriEscapeUnescape:

  Enabled: false

Lint/UriRegexp:

  Enabled: false

Lint/UselessMethodDefinition:

  Enabled: false

Lint/UselessTimes:

  Enabled: false

Metrics/AbcSize:

  Enabled: false

Metrics/BlockLength:

  Enabled: false

Metrics/BlockNesting:

  Enabled: false

Metrics/ClassLength:

  Enabled: false

Metrics/CyclomaticComplexity:
@@ -119,19 +255,265 @@ Metrics/ParameterLists: 
  Enabled: false

Metrics/PerceivedComplexity:

  Enabled: false

Migration/DepartmentName:

  Enabled: false

Naming/AccessorMethodName:

  Enabled: false

Naming/BlockParameterName:

  Enabled: false

Naming/HeredocDelimiterCase:

  Enabled: false

Naming/HeredocDelimiterNaming:

  Enabled: false

Naming/MemoizedInstanceVariableName:

  Enabled: false

Naming/MethodParameterName:

  Enabled: false

Naming/RescuedExceptionsVariableName:

  Enabled: false

Naming/VariableNumber:

  Enabled: false

Performance/BindCall:

  Enabled: false

Performance/DeletePrefix:

  Enabled: false

Performance/DeleteSuffix:

  Enabled: false

Performance/InefficientHashSearch:

  Enabled: false

Performance/UnfreezeString:

  Enabled: false

Performance/UriDefaultParser:

  Enabled: false

RSpec/Be:

  Enabled: false

RSpec/Capybara/CurrentPathExpectation:

  Enabled: false

RSpec/Capybara/FeatureMethods:

  Enabled: false

RSpec/Capybara/VisibilityMatcher:

  Enabled: false

RSpec/ContextMethod:

  Enabled: false

RSpec/ContextWording:

  Enabled: false

RSpec/DescribeClass:

  Enabled: false

RSpec/EmptyHook:

  Enabled: false

RSpec/EmptyLineAfterExample:

  Enabled: false

RSpec/EmptyLineAfterExampleGroup:

  Enabled: false

RSpec/EmptyLineAfterHook:

  Enabled: false

RSpec/ExampleLength:

  Enabled: false

RSpec/MessageExpectation:

RSpec/ExampleWithoutDescription:

  Enabled: false

RSpec/ExpectChange:

  Enabled: false

RSpec/ExpectInHook:

  Enabled: false

RSpec/FactoryBot/AttributeDefinedStatically:

  Enabled: false

RSpec/FactoryBot/CreateList:

  Enabled: false

RSpec/FactoryBot/FactoryClassName:

  Enabled: false

RSpec/HooksBeforeExamples:

  Enabled: false

RSpec/ImplicitBlockExpectation:

  Enabled: false

RSpec/ImplicitSubject:

  Enabled: false

RSpec/LeakyConstantDeclaration:

  Enabled: false

RSpec/LetBeforeExamples:

  Enabled: false

RSpec/MissingExampleGroupArgument:

  Enabled: false

RSpec/MultipleExpectations:

  Enabled: false

RSpec/MultipleMemoizedHelpers:

  Enabled: false

RSpec/MultipleSubjects:

  Enabled: false

RSpec/NestedGroups:

  Enabled: false

RSpec/PredicateMatcher:

  Enabled: false

RSpec/ReceiveCounts:

  Enabled: false

RSpec/ReceiveNever:

  Enabled: false

RSpec/RepeatedExampleGroupBody:

  Enabled: false

RSpec/RepeatedExampleGroupDescription:

  Enabled: false

RSpec/RepeatedIncludeExample:

  Enabled: false

RSpec/ReturnFromStub:

  Enabled: false

RSpec/SharedExamples:

  Enabled: false

RSpec/StubbedMock:

  Enabled: false

RSpec/UnspecifiedException:

  Enabled: false

RSpec/VariableDefinition:

  Enabled: false

RSpec/VoidExpect:

  Enabled: false

RSpec/Yield:

  Enabled: false

Security/Open:

  Enabled: false

Style/AccessModifierDeclarations:

  Enabled: false

Style/AccessorGrouping:

  Enabled: false

Style/AsciiComments:

  Enabled: false

Style/BisectedAttrAccessor:

  Enabled: false

Style/CaseLikeIf:

  Enabled: false

Style/ClassEqualityComparison:

  Enabled: false

Style/ColonMethodDefinition:

  Enabled: false

Style/CombinableLoops:

  Enabled: false

Style/CommentedKeyword:

  Enabled: false

Style/Dir:

  Enabled: false

Style/DoubleCopDisableDirective:

  Enabled: false

Style/EmptyBlockParameter:

  Enabled: false

Style/EmptyLambdaParameter:

  Enabled: false

Style/Encoding:

  Enabled: false

Style/EvalWithLocation:

  Enabled: false

Style/ExpandPathArguments:

  Enabled: false

Style/ExplicitBlockArgument:

  Enabled: false

Style/ExponentialNotation:

  Enabled: false

Style/FloatDivision:

  Enabled: false

Style/FrozenStringLiteralComment:

  Enabled: false

Style/GlobalStdStream:

  Enabled: false

Style/HashAsLastArrayItem:

  Enabled: false

Style/HashLikeCase:

  Enabled: false

Style/HashTransformKeys:

  Enabled: false

Style/HashTransformValues:

  Enabled: false

Style/IfUnlessModifier:

  Enabled: false

Style/KeywordParametersOrder:

  Enabled: false

Style/MinMax:

  Enabled: false

Style/MixinUsage:

  Enabled: false

Style/MultilineWhenThen:

  Enabled: false

Style/NegatedUnless:

  Enabled: false

Style/NumericPredicate:

  Enabled: false

Style/OptionalBooleanParameter:

  Enabled: false

Style/OrAssignment:

  Enabled: false

Style/RandomWithOffset:

  Enabled: false

Style/RedundantAssignment:

  Enabled: false

Style/RedundantCondition:

  Enabled: false

Style/RedundantConditional:

  Enabled: false

Style/RedundantFetchBlock:

  Enabled: false

Style/RedundantFileExtensionInRequire:

  Enabled: false

Style/RedundantRegexpCharacterClass:

  Enabled: false

Style/RedundantRegexpEscape:

  Enabled: false

Style/RedundantSelfAssignment:

  Enabled: false

Style/RedundantSort:

  Enabled: false

Style/RescueStandardError:

  Enabled: false

Style/SingleArgumentDig:

  Enabled: false

Style/SlicingWithRange:

  Enabled: false

Style/SoleNestedConditional:

  Enabled: false

Style/StderrPuts:

  Enabled: false

Style/StringConcatenation:

  Enabled: false

Style/Strip:

  Enabled: false

Style/SymbolProc:

  Enabled: false

Style/TrailingBodyOnClass:

  Enabled: false

Style/TrailingBodyOnMethodDefinition:

  Enabled: false

Style/TrailingBodyOnModule:

  Enabled: false

Style/TrailingCommaInHashLiteral:

  Enabled: false

Style/TrailingMethodEndStatement:

  Enabled: false

Style/UnpackFirst:

  Enabled: false

Lint/DuplicateBranch:

  Enabled: false

Lint/DuplicateRegexpCharacterClassElement:

  Enabled: false

Lint/EmptyBlock:

  Enabled: false

Lint/EmptyClass:

  Enabled: false

Lint/NoReturnInBeginEndBlocks:

  Enabled: false

Lint/ToEnumArguments:

  Enabled: false

Lint/UnexpectedBlockArity:

  Enabled: false

Lint/UnmodifiedReduceAccumulator:

  Enabled: false

Performance/CollectionLiteralInLoop:

  Enabled: false

Style/ArgumentsForwarding:

  Enabled: false

Style/CollectionCompact:

  Enabled: false

Style/DocumentDynamicEvalDefinition:

  Enabled: false

Style/NegatedIfElseCondition:

  Enabled: false

Style/NilLambda:

  Enabled: false

Style/RedundantArgument:

  Enabled: false

Style/SwapValues:

  Enabled: false