fix(networking): allow connections from local

When connected from localhost, allow from local ip too

issue #1099

lib/Ravada/Domain.pm

@@ -2521,6 +2521,9 @@ sub _add_iptable {
     $self->_remove_iptables( port => $local_port );
 
     $self->_open_port($user, $remote_ip, $local_ip, $local_port);
+    if ($remote_ip eq '127.0.0.1' ) {
+        $self->_open_port($user, $self->_vm->ip, $local_ip, $local_port);
+    }
     $self->_close_port($user, '0.0.0.0/0', $local_ip, $local_port);
 
 }
@@ -2632,13 +2635,6 @@ sub open_iptables {
 
     $self->_add_iptable(%args);
 
-    my $remote_ip = $args{remote_ip};
-    if ($remote_ip && $remote_ip =~ /^127\./) {
-        my %args2 = %args;
-        $args2{local_ip} = $self->_vm->ip;
-        $self->_add_iptable(%args2);
-    }
-
     $self->info($user);
 }
 

t/vm/91_fw_req.t

@@ -60,17 +60,15 @@ sub test_fw_domain($vm_name, $domain_name, $remote_ip='99.88.77.66') {
     my $local_port;
     my $domain_id;
 
+    my $vm = rvd_back->search_vm($vm_name);
     {
-        my $vm = rvd_back->search_vm($vm_name);
         my $domain = $vm->search_domain($domain_name);
         ok($domain,"Searching for domain $domain_name") or return;
         $domain->shutdown_now($USER) if $domain->is_active;
         $domain->start( user => $USER, remote_ip => $remote_ip);
 
         my $display = $domain->display($USER);
-        ($local_port) = $display =~ m{\d+\.\d+\.\d+\.\d+\:(\d+)};
-        $local_ip = $vm->ip;
-        $local_ip = $vm->public_ip if $vm->public_ip;
+        ($local_ip, $local_port) = $display =~ m{(\d+\.\d+\.\d+\.\d+)\:(\d+)};
 
         ok(defined $local_port, "Expecting a port in display '$display'") or return;
     
@@ -95,6 +93,11 @@ sub test_fw_domain($vm_name, $domain_name, $remote_ip='99.88.77.66') {
         is($req->status,'done');
         is($req->error,'');
         test_chain($vm_name, $local_ip,$local_port, $remote_ip, 1);
+        if ($remote_ip eq '127.0.0.1') {
+            my $if_ip = $vm->ip;
+            isnt($if_ip,'127.0.0.1');
+            test_chain($vm_name, $local_ip,$local_port, $if_ip, 1);
+        }
     }