[-dev] Moving critic.t from t/ into xt/.

git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@12165 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

Makefile.am

@@ -43,8 +43,10 @@ check_DATA = \
 	t/pki/key/ca.pem \
 	t/pki/key/rousse_nopassword.pem \
 	t/pki/key/rousse_password.pem \
-	t/stub/Sympa/Constants.pm
+	t/stub/Sympa/Constants.pm \
+	xt/perlcriticrc
 noinst_SCRIPTS = \
+	xt/critic.t \
 	xt/pod-coverage.t \
 	xt/pod-spelling.t \
 	xt/pod-syntax.t
@@ -71,8 +73,9 @@ check-local:
 	$(PERL) -MTest::Harness -e 'runtests @ARGV' $$TEST_FILES
 
 authorcheck:
+	[ -z "$(TEST_FILES)" ] && TEST_FILES="$(noinst_SCRIPTS)"; \
 	PERL5LIB=src/lib; export PERL5LIB; \
-	$(PERL) -MTest::Harness -e 'runtests @ARGV' $(noinst_SCRIPTS)
+	$(PERL) -MTest::Harness -e 'runtests @ARGV' $$TEST_FILES
 
 install-data-hook: installdir installconfig nextstep importantchanges
 

t/critic.t

-#!/usr/bin/perl
-# -*- indent-tabs-mode: t; -*-
-# vim:ft=perl:et:sw=4
-# $Id: critic.c 8606 2013-02-06 08:44:02Z rousse $
-
-use strict;
-use warnings;
-
-use FindBin qw($Bin);
-use lib "$Bin/../src/lib";
-
-use English qw(-no_match_vars);
-use Test::More;
-
-plan(skip_all => 'Author test, set $ENV{TEST_AUTHOR} to a true value to run')
-    if !$ENV{TEST_AUTHOR};
-
-eval {
-    require Test::Perl::Critic;
-    Test::Perl::Critic->import();
-};
-plan(skip_all => 'Test::Perl::Critic required') if $EVAL_ERROR;
-
-Test::Perl::Critic->import(-profile => 't/perlcriticrc');
-
-all_critic_ok('src/lib');

xt/critic.t

+# -*- indent-tabs-mode: t; -*-
+# vim:ft=perl:et:sw=4
+# $Id$
+
+use strict;
+use warnings;
+use English qw(-no_match_vars);
+use Test::More;
+
+BEGIN {
+    eval { use Test::Perl::Critic -profile => 'xt/perlcriticrc'; };
+}
+plan(skip_all => 'Test::Perl::Critic required')
+    unless $Test::Perl::Critic::VERSION;
+
+all_critic_ok('src/lib');