Skip to content
GitLab
This project is mirrored from https://github.com/sympa-community/sympa.git. Pull mirroring updated .
  1. 04 Aug, 2014 1 commit
  3. 31 Jul, 2014 2 commits
  5. 27 Jul, 2014 1 commit
  7. 26 Jul, 2014 2 commits
  9. 25 Jul, 2014 1 commit
  11. 21 Jul, 2014 1 commit
  13. 20 Jul, 2014 1 commit
    • sikeda's avatar
      [dev] Refactoring Message module: Preventing breakage of message contents by re-encoding MIME. · 4a2d6254
      sikeda authored 
      - The {msg} item of Message object does no longer represent actual content: Original string representation will be kept as far as possible.
- {msg_as_string} was splitted to {_head} (MIME::Head entity) and {_body} (body as string).  Accessors are head(), header_as_string(), body_as_string() and as_string().
- For now don't access to {msg}, {_head} and {_body} items directly: Use as_entity() and methods above.
- add_header(), delete_header() or replace_header() should be used to modify {_head}.  get_header() may be used to get header fields (only at the top level of structure).
- {orig_msg} item was replaced by {orig_msg_as_string} to prevent reencoding, too.
- To get message ID, sender and so on, use items {message_id}, {sender} and so on of objects, not using get_header() etc.
- See also POD.

ToDo: Some components (probably bulk.pl etc.) still reencode contents.


git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11209 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce
      4a2d6254
  15. 17 Jul, 2014 1 commit
    • sikeda's avatar
      [dev] Starting refactoring to correct behavior on message processing. · 1c683daa
      sikeda authored 
      - X-Sympa-*: header fields are stripped at first of message parsing.  They will no longer included into outgoing messages.
- Conversely, new Message::to_string() adds header fields above at the top of serialized messages.
- Message::new() now takes string and metadata as argument: MIME::Entity instance, "message_in_spool" hashref and filename are omitted.
- Tentative Message::new_from_file() is a wrapper of above.  It may be removed when refactoring will completed.
- New tools::unmarshal_metadata() to explode metadata from file name of spooled message.  This uses new tools::split_listname() utility function to analyze list identifiers.
- sympa ::DoFile() was renamed to process_message() and takes Message as argument.
- Message::check_param_status() and Message::check_dkim_signature() are separated from Message::new(), because they are needed by incoming messages (in "msg" queue).  ToDo: decrypt() and check_smime_Signature() should be also handled in the same way.
- mail::mail_file() changed its prototype.  ToDo: this would be splitted into Message::new_from_template() and mail::sending().


git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11167 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce
      1c683daa
  17. 11 Jul, 2014 1 commit
  19. 28 Jun, 2014 1 commit
  21. 05 Jun, 2014 2 commits
  23. 28 May, 2014 1 commit
  25. 23 May, 2014 2 commits
    • sikeda's avatar
      [*change] Reformatting Perl sources using perltidy, · 9da4473e
      sikeda authored 
      except: src/lib/Challenge.pm, src/lib/WebAgent.pm and files under ext/.
Additionally reparing long comment lines.

Used configuration for perltidy (.perltidyrc) is approximately:
------------ >8 ------------ >8 ------------ >8 ------------
# Differences from PBP are marked *.
-bar   # Opening brace always on right (* no)
-bbt=1 # Medium block brace tightness
-bt=2  # Strong brace tightness (* 1)
-ce    # Cuddled else (* no)
-cti=0 # No extra indentation for closing brackets
-i=4   # Indent level is 4 cols
-ci=4  # Continuation indent is 4 cols
-l=78  # Max line witdh is 78 cols
-nolc  # Don't outdent long comments (* -olc)
-nolq  # Don't outdent long quoted strings
-nsbl  # No opening sub brace on new line (* -sbl)
-nsfs  # No space before semicolons
-pt=2  # Strong parenthesis tightness (* 1)
-sbcp='#' # Don't format non-static block comments automatically (* '##')
-sbt=2 # Strong square bracket tightness (* 1)
-se    # Errors to STDERR
#-st   # Output to STDOUT
-vt=2  # Maximal vertical tightness
-wba="% + - * / x != == >= <= =~ !~ < > | & >= < = **= += *= &= <<= &&= -= /= |= >>= ||= .= %= ^= x="
# Break after all operators
------------ 8< ------------ 8< ------------ 8< ------------


git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@10721 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce
      9da4473e
    • sikeda's avatar
      [dev] Won't use exported symbols anymore, and use "base" pragma instead of... · 7abfc64a
      sikeda authored 
      [dev] Won't use exported symbols anymore, and use "base" pragma instead of "our @ISA" magic variable.


git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@10706 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce
      7abfc64a
  27. 22 May, 2014 3 commits
  29. 20 May, 2014 1 commit
  31. 13 May, 2014 1 commit
  33. 10 Mar, 2014 1 commit
  35. 02 Mar, 2014 1 commit
    • sikeda's avatar
      [bug] viewmod only shows message source. · 33b6e73f
      sikeda authored 
      - Generate HTML view of moderated messages in dedicated directory specified by viewmail_dir parameter.
- Avoid using trivial TT2 tag which gives attackers a chance to execute arabitrary TT2 directives: Use new Archive::convert_single_message() to generate non-trivial tags.
- Archive::convert_single_msg_2_html() and archived.pl::get_tag() was deprecated.


git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@10323 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce
      33b6e73f
  37. 10 Feb, 2014 2 commits
  39. 13 Jan, 2014 1 commit
  41. 12 Jan, 2014 1 commit
  43. 10 Jan, 2014 1 commit
  45. 08 Jan, 2014 1 commit
  47. 19 Jul, 2013 2 commits
  49. 05 Jul, 2013 1 commit
  51. 04 Jul, 2013 1 commit
  53. 03 Jul, 2013 1 commit
  55. 10 Jun, 2013 1 commit
  57. 24 Apr, 2013 1 commit
  59. 17 Apr, 2013 1 commit
  61. 02 Apr, 2013 1 commit
  63. 01 Apr, 2013 1 commit