[bug] Could not check S/MIME signature if the message was encrypted.  An S/MIME message may be nested either as "encrypted then signed" or as "signed then encrypted", however we didn't check latter case.


git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11239 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

[dev] Refactoring: Now messages only in msg spool would be decrypted; those in other spools are assumed being already decrypted (or failing decription).  Exception is "outgoing" (archive) spool: It may contain original messages if archive_crypted_msg parameter is "original"; also, wwsympa::do_send_me() and List::archive_send_last() should decrypt messages before sending them.
As a side effect, Message->new() no longer takes noxsympato parameter.  Now messages are always stored into spools in "serialized" form (with prepended X-Sympa-*: pseudo-header fields) and deserialized by Message->new().

Issue: Is it allowable that decrypted messages are stored into spools?


git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11238 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11237 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

[dev] Updating mod2html.pl.  Though 6.2a.32 or earlier stored HTML view into modqueue, now dedicated directory specified by viewmail_dir parameter is used.

ToDo: Upgrade would call mod2html.pl instead of using redundant code.


git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11236 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11235 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11234 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11233 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11232 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

[-bug] According to RFC 4871, new DKIM-Signature header field should not be appended to header but be prepended.


git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11231 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11230 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

This is caused by refolding of  base64 and quoted-printable contents: Signatures are kept.  Fixed by keeping original content if MIME structure were not really changed.

n.b. Though I previously compared binary form using Storable::freeze, this method was incompetent.  Now MIME::Entity::as_string is used.


git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11229 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

- Moved tools::remove_invalid_dkim_signature() to Message::remove_invalid_dkim_signature() which alters Message object itself.
- Moved tools::dkim_sign() to Message::dkim_sign() which alters Message object itself.
- Message::personalize() skip processing message if it's encrypted or signed.
- bulk.pl processes Message object instead of stringified messages.


git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11228 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

[dev] Refactoring: Move tools::smime_sign() to Message::smime_sign(), and now it alters Message object itself.


git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11227 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

- Moved %openssl_errors from tools to Message.
- Now Message::new() returns message even if no sender found.
- Message::check_smime_sign() checks if smime-type parameter is "signed-data".
and several copyedits.


git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11226 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

- Now smime_decrypt() set {smime_*} attributes of Message object itself.
- Fix broken check_smime_signature(): When message has been decrypted, use {orig_msg_as_string}.
- Coding: use $self as subject of instance methods.
- Suppress "Use of uninitialized value in pattern match (m//)" warnings.


git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11225 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

[dev] Refactoring: Moved tools::smime_sign_check() to Message::check_smime_signature(), and made it to set {smime_*} attributes of Message object itself.
And now, since this method will be called only by sympa.pl, it no longer called from inside of constructor.


git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11224 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11223 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11222 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11219 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

[dev] Refactoring: rename tools::smime_encrypt() to Message::smime_encrypt(), and now it modify message itself.


git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11214 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11213 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

[dev] (con'd r11167) Stringified message returned by Message::as_string() now contains Return-Path: pseudo-header field, because it is useful for moderation etc.  Conversely, such field should be removed when the message is passed to sendmail command: Some implementations won't strip it automatically.

Issue: May messages in MIME digest contain original Return-Path:?


git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11212 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

[bug] Messages attached to system messages, such as moderation notifications, were altered.  As a result, for example, editors could not verify signature in attached messages.
This was caused by that attachments were always parsed and stringified again.  Now stringified attachments won't be parsed anymore.


git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11211 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11210 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

- The {msg} item of Message object does no longer represent actual content: Original string representation will be kept as far as possible.
- {msg_as_string} was splitted to {_head} (MIME::Head entity) and {_body} (body as string).  Accessors are head(), header_as_string(), body_as_string() and as_string().
- For now don't access to {msg}, {_head} and {_body} items directly: Use as_entity() and methods above.
- add_header(), delete_header() or replace_header() should be used to modify {_head}.  get_header() may be used to get header fields (only at the top level of structure).
- {orig_msg} item was replaced by {orig_msg_as_string} to prevent reencoding, too.
- To get message ID, sender and so on, use items {message_id}, {sender} and so on of objects, not using get_header() etc.
- See also POD.

ToDo: Some components (probably bulk.pl etc.) still reencode contents.


git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11209 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11208 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11173 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11172 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

[-bug] Fixing bugs that made sympa.pl crash when distributing a crypted message. This was due to a useless decrypting when sending the message to final receipient. Decrypting is useless because Sympa sends the message, so we already know what's in the message at this point - and no further scenario evaluation will be done.

git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11171 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11170 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11169 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11168 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

- X-Sympa-*: header fields are stripped at first of message parsing.  They will no longer included into outgoing messages.
- Conversely, new Message::to_string() adds header fields above at the top of serialized messages.
- Message::new() now takes string and metadata as argument: MIME::Entity instance, "message_in_spool" hashref and filename are omitted.
- Tentative Message::new_from_file() is a wrapper of above.  It may be removed when refactoring will completed.
- New tools::unmarshal_metadata() to explode metadata from file name of spooled message.  This uses new tools::split_listname() utility function to analyze list identifiers.
- sympa ::DoFile() was renamed to process_message() and takes Message as argument.
- Message::check_param_status() and Message::check_dkim_signature() are separated from Message::new(), because they are needed by incoming messages (in "msg" queue).  ToDo: decrypt() and check_smime_Signature() should be also handled in the same way.
- mail::mail_file() changed its prototype.  ToDo: this would be splitted into Message::new_from_template() and mail::sending().


git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11167 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11166 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11165 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11164 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

Use this time as the delivery date inserted into bulk_table unless delivery_date parameter is not defined.


git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11163 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11162 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

[dev] Getting back reception_date_bulkmailer field: Now it has double type to get precise date/time of storage into bulk spool.


git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11161 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce

[change] (r11007, r11158) Again, file extensions of lock files are changed from ".lock" to ",lock" (comma and "lock"), because names including full stop can conflict with domain parts.  Temporary files created by Sympa::LockedFile are also renamed in similar way.


git-svn-id: https://subversion.renater.fr/sympa/branches/sympa-6.2-branch@11160 05aa8bb8-cd2b-0410-b1d7-8918dfa770ce